1599729 - Remove security.identityblock.show_extended_validation pref and related UI code

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P3)

Description

[Dão Gottwald [:dao]]

Since we've successfully shipped security.identityblock.show_extended_validation=false, we should remove this pref and the UI code responsible for showing the EV label in the address bar.

Comment 1

[Johann Hofmann [:johannh]]

Also note that there's a bunch of serialization happening in webprogress to show EV data when loading websites. With the active/primary EV indicators gone, we could lazily fetch cert data using WindowGlobal.getSecurityInfo() when the user opens the identity panel to avoid serializing and sending cert data on security change.

Reading the data for EV happens here: https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/browser/base/content/browser-siteIdentity.js#467

Sending from the child here: https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/dom/ipc/BrowserChild.cpp#3807

Would be nice to do it at the same time or at least have a follow-up for this, as there's a potential perf benefit.

Comment 2

[Jayati Shrivastava]

Hello, May I work on this?

Comment 3

[Jayati Shrivastava]

Are we to completely remove support for security.identityblock.show_extended_validation and security.secure_connection_icon_color_gray ?
Currently the EV indicators are just disabled by default. Am I correct?

Comment 4

[Jayati Shrivastava]

Attachment: Bug 1599729 - Remove security.identityblock.show_extended_validation pref and related UI code. r=dao

Comment 5

[Johann Hofmann [:johannh]]

Yup

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd53e57b244b
Remove security.identityblock.show_extended_validation pref and related UI code. r=dao

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset dd53e57b244b for causing multiple bc failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f380f756a87f6e3b08cbd2869ecb480cc8ee8913

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=f380f756a87f6e3b08cbd2869ecb480cc8ee8913&fromchange=dd53e57b244b8cd8cd500963a1722722f194a41d&failure_classification_id=2&selectedJob=295046820

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295046820&repo=autoland&lineNumber=40914
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295046821&repo=autoland&lineNumber=25492
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295046893&repo=autoland&lineNumber=4693
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295047344&repo=autoland&lineNumber=1235
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295050243&repo=autoland&lineNumber=4292
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295050186&repo=autoland&lineNumber=3254
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295050221&repo=autoland&lineNumber=2429

Comment 8

[Jayati Shrivastava]

will update the tests.

Comment 9

[Dão Gottwald [:dao]]

(In reply to Jayati Shrivastava from comment #8)

will update the tests.

Do you need help with this?

Comment 10

[Jayati Shrivastava]

The tests that are failing aren't directly related to the patch. I haven't yet been able to trace the error. Will be great if you could take a look :)

Comment 11

[Dão Gottwald [:dao]]

commented in phabricator

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63abe62205ee
Remove security.identityblock.show_extended_validation pref and related UI code. r=dao

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/63abe62205ee